Calendar: Add slotDuration and slotLabelInterval, Add Day View#8880
Calendar: Add slotDuration and slotLabelInterval, Add Day View#8880BeatLink wants to merge 17 commits intoTriliumNext:mainfrom
Conversation
dosubot
bot
added
the
size:M
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the calendar widget by providing users with greater control over its time-based display. It enables dynamic configuration of time slot durations and label intervals directly through note labels, making the calendar more adaptable to various scheduling needs. This change improves the flexibility and user experience of the calendar feature without altering its core functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces slotDuration and slotLabelInterval attributes to the Calendar view, allowing users to configure them through note labels. The implementation is sound, and the documentation has been updated accordingly. My review includes suggestions to improve code maintainability by extracting hardcoded default values into constants, and to enhance the documentation by adding information about these default values and ensuring consistent formatting.
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request adds the ability to configure slotDuration and slotLabelInterval for the calendar view using note labels. The implementation is straightforward and follows existing patterns. I've identified a potential bug where an empty label value would be passed to the calendar component, which could cause issues. I've included a suggestion to fix this. I also have a minor suggestion for improving code organization.
There was a problem hiding this comment.
Code Review
This pull request successfully adds the slotDuration and slotLabelInterval attributes to the Calendar widget, allowing users to customize these FullCalendar properties via note labels. The changes include defining default constants, retrieving values from note labels, passing them to the FullCalendar component, updating the Labels type for type safety, and documenting the new attributes in the user guide.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@eliandoran can you take a look? |
|
@eliandoran @SiriusXT could we get this in for the next release? |
BeatLink
changed the title
1 participant
This PR allows the user to set the FullCalendar slotDuration and slotLabelInterval attributes using note labels on the calendar.
This PR also adds day view as a selectable option