X Tutup
Skip to content

Add Graph3 (add DFS in Iterative Way)#944

Merged
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
Open-Source-Contribute:master
Mar 24, 2022
Merged

Add Graph3 (add DFS in Iterative Way)#944
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
Open-Source-Contribute:master

Conversation

@devycha
Copy link
Contributor

@devycha devycha commented Mar 22, 2022 •
edited
Loading

Welcome to the JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • [o] New Implementation of Data Structure

Checklist:

  • [o] I have read CONTRIBUTING.md.
  • [o] This pull request is all my own work -- I have not plagiarized.
  • [o] I know that pull requests will not be merged if they fail the automated tests.
  • [o] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [o] All new JavaScript files are placed inside an existing directory.
  • [o] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [o] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [o] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@devycha devycha requested a review from raklaptudirm as a code owner March 22, 2022 11:00
@devycha
Copy link
Contributor Author

devycha commented Mar 22, 2022

I have my first time contributing Open Source Project.
Is it OK what I did?

raklaptudirm
raklaptudirm requested changes Mar 22, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write unit tests for your algorithm in jest.

@devycha
Copy link
Contributor Author

devycha commented Mar 23, 2022

@raklaptudirm
I apologize to disturb you, Is ther anything to do more to get permission for merge?

raklaptudirm
raklaptudirm requested changes Mar 24, 2022
View reviewed changes
raklaptudirm
raklaptudirm approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the community!

@raklaptudirm raklaptudirm merged commit 233ec59 into TheAlgorithms:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devycha @raklaptudirm
X Tutup