Create firstRelativeMaxPointInArray.js #772
Merged
raklaptudirm merged 14 commits intoTheAlgorithms:masterfrom Oct 28, 2021
Merged
Create firstRelativeMaxPointInArray.js #772raklaptudirm merged 14 commits intoTheAlgorithms:masterfrom
raklaptudirm merged 14 commits intoTheAlgorithms:masterfrom
Conversation
go over randomly generated array and print first spike or maximum point index in it runs in O(log(n))
jhonDoe15
changed the title
Contributor
Author
|
I'd appreciate a code review |
raklaptudirm
requested changes
Oct 20, 2021
Member
raklaptudirm
left a comment
raklaptudirm
left a comment
There was a problem hiding this comment.
Provide references and comments as to what you are doing.
I prefer SOLID standards so that's why didn't add them at first but due to the repository requirements was needed to be added
raklaptudirm
requested changes
Oct 21, 2021
raklaptudirm
added
algorithm
Contributor
Author
|
All taken care of as requested and suggested |
raklaptudirm
requested changes
Oct 28, 2021
Member
raklaptudirm
left a comment
raklaptudirm
left a comment
There was a problem hiding this comment.
Move the test file into the /test folder.
raklaptudirm
requested changes
Oct 28, 2021
Member
raklaptudirm
left a comment
raklaptudirm
left a comment
There was a problem hiding this comment.
Remove the changes to package-lock.json.
Contributor
Author
when I install the dependencies locally is makes those changes |
Member
|
The tests are failing because of that, so remove it. I will check what is wrong. |
raklaptudirm
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go over randomly generated array and print first spike or maximum point index in it
runs in O(log(n))
Welcome to JavaScript community
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare not