X Tutup
Skip to content

Bucket sort tests#736

Merged
raklaptudirm merged 8 commits intoTheAlgorithms:masterfrom
charliejmoore:bucket-sort-tests
Oct 6, 2021
Merged

Bucket sort tests#736
raklaptudirm merged 8 commits intoTheAlgorithms:masterfrom
charliejmoore:bucket-sort-tests

Conversation

@charliejmoore
Copy link
Copy Markdown
Contributor

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Add tests

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

…o the sort function

The [built-in JavaScript sort method](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort) will
perform a lexicographical (aka alphabetical) order by converting the elements of the array to strings. This can yield unexpected results when sorting numbers.
A comparison function can be passed into the sort method to indicate how array elements should be compared.
@raklaptudirm raklaptudirm merged commit 2e6f8ae into TheAlgorithms:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup