X Tutup
Skip to content

✨ add an algorithm for checking a year is a leap year or not.#726

Merged
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom
ahamed:master
Oct 6, 2021
Merged

✨ add an algorithm for checking a year is a leap year or not.#726
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom
ahamed:master

Conversation

@ahamed
Copy link
Copy Markdown
Contributor

@ahamed ahamed commented Oct 3, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ahamed
Copy link
Copy Markdown
Contributor Author

ahamed commented Oct 3, 2021

Hello maintainer,
If the PR is accepted then please labeled it hecktoberfest-accepted as I want to contribute to the hecktoberfest2021.
BTW, thanks for the awesome repo.

@raklaptudirm
Copy link
Copy Markdown
Member

In my opinion, this is a trivial algorithm. Maintainers, if you have a different opinion, please let me know.

@raklaptudirm raklaptudirm added the on hold Being discussed by the maintainers label Oct 4, 2021
@ahamed
Copy link
Copy Markdown
Contributor Author

ahamed commented Oct 4, 2021

Hello @raklaptudirm,
Thanks for your response. The algorithm is trivial but cannot be ignored. And I've seen that there also other small algorithms there, that's why I've written that function.

BTW, I've seriously like the repository and wish to contribute more.

@raklaptudirm
Copy link
Copy Markdown
Member

Of course, please contribute more. I was saying that because the repo already has a lot of helper functions which check if a year is leap or not.

@ahamed
Copy link
Copy Markdown
Contributor Author

ahamed commented Oct 4, 2021

I've checked the DIRECTORY.md file and didn't find any. May be I've missed that.

@trasherdk
Copy link
Copy Markdown
Contributor

It's in there, the leap year thingy.

$ search leap 
./Timing-Functions/GetMonthDays.js:23:  // Check for Leap year

@ahamed ahamed requested a review from raklaptudirm as a code owner October 4, 2021 15:13
@raklaptudirm
Copy link
Copy Markdown
Member

Please remove changes in package.json and package-lock.json.

@ahamed
Copy link
Copy Markdown
Contributor Author

ahamed commented Oct 5, 2021

Hey @raklaptudirm, I've rolled back the package.json and package-lock.json files and fix the conflicts.

@raklaptudirm
Copy link
Copy Markdown
Member

The implementation and comments are good, so I am merging it.

@raklaptudirm raklaptudirm merged commit 7e419f0 into TheAlgorithms:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold Being discussed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup