Rewrote "Rat in a maze" algorithm + added tests#714
Merged
pomkarnath98 merged 4 commits intoTheAlgorithms:masterfrom Oct 3, 2021
defaude:test/Backtracking/RatInAMaze
Merged
Rewrote "Rat in a maze" algorithm + added tests#714pomkarnath98 merged 4 commits intoTheAlgorithms:masterfrom defaude:test/Backtracking/RatInAMaze
pomkarnath98 merged 4 commits intoTheAlgorithms:masterfrom
defaude:test/Backtracking/RatInAMaze
Conversation
It's based on the previous implementation but offers a better API and is now properly testable, too
Member
|
Again @defaude |
Contributor
Author
|
Hi @pomkarnath98 :) As with #713 , I still think contributing test-cases to already-existing algorithms is valid (and wanted). Regarding my re-write: True, the existing version worked. It was a bit hard to read, though, and even harder to properly test. So I decided to propose a new implementation that improves a few things:
|
(and added a missing comment)
Contributor
Author
|
Update: I gave @chiranjeev-thapliyal credit as the original implementation's author in the documentation block 👍 |
Member
|
@defaude Please format your code with |
Sadly, standard does not support private fields (yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare not