X Tutup
Skip to content

Implement binary to decimal#264

Merged
itsvinayak merged 3 commits intoTheAlgorithms:masterfrom
neha-saggam:neha-saggam/binary-to-decimal
Aug 20, 2020
Merged

Implement binary to decimal#264
itsvinayak merged 3 commits intoTheAlgorithms:masterfrom
neha-saggam:neha-saggam/binary-to-decimal

Conversation

@neha-saggam
Copy link
Copy Markdown
Contributor

@neha-saggam neha-saggam commented Aug 16, 2020 •
edited
Loading

Welcome to JavaScript community

Describe your change:

  • Implemented binary to decimal

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@itsvinayak itsvinayak added the code style issue Failing style checks label Aug 19, 2020
@itsvinayak
Copy link
Copy Markdown
Member

itsvinayak commented Aug 19, 2020

@neha-saggam please read CONTRIBUTING.md some of the tests are falling
thank you
@itsvinayak

@neha-saggam
Copy link
Copy Markdown
Contributor Author

neha-saggam commented Aug 19, 2020

@itsvinayak When I run npm run test it fails on local saying echo "Error: no test specified" && exit 1 how do I resolve it ? Do I have to write tests for this, if yes I don't see any tests for reference

@itsvinayak
Copy link
Copy Markdown
Member

itsvinayak commented Aug 19, 2020 •
edited
Loading

hey @neha-saggam currently, this repo does not contain any test as such,
run npx standard --fix read more here to format the code

@neha-saggam
Copy link
Copy Markdown
Contributor Author

neha-saggam commented Aug 20, 2020

@itsvinayak Thank you! All checks have passed now 🙂 , it was missing end of line. I had already ran the npm standards command but somehow missed this. Maybe we can add a pre-push hook for this ? Thoughts ?

itsvinayak
itsvinayak requested changes Aug 20, 2020
View reviewed changes
@itsvinayak
Copy link
Copy Markdown
Member

itsvinayak commented Aug 20, 2020

@itsvinayak Thank you! All checks have passed now , it was missing end of line. I had already ran the npm standards command but somehow missed this. Maybe we can add a pre-push hook for this ? Thoughts ?

we are working on pre-push hook, you are welcome to implement ...

@itsvinayak itsvinayak added changes required This pull request needs changes and removed code style issue Failing style checks labels Aug 20, 2020
@neha-saggam neha-saggam reopened this Aug 20, 2020
@itsvinayak itsvinayak merged commit 157345c into TheAlgorithms:master Aug 20, 2020
@neha-saggam neha-saggam deleted the neha-saggam/binary-to-decimal branch August 21, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsvinayak itsvinayak itsvinayak requested changes

Assignees

No one assigned

Labels

changes required This pull request needs changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neha-saggam @itsvinayak
X Tutup