X Tutup
Skip to content

Number of Subset equal to given sum#174

Merged
itsvinayak merged 3 commits intoTheAlgorithms:masterfrom
rverma13927:master
May 22, 2020
Merged

Number of Subset equal to given sum#174
itsvinayak merged 3 commits intoTheAlgorithms:masterfrom
rverma13927:master

Conversation

@rverma13927
Copy link
Copy Markdown
Contributor

@rverma13927 rverma13927 commented May 21, 2020 •
edited
Loading

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@itsvinayak
Copy link
Copy Markdown
Member

itsvinayak commented May 21, 2020 •
edited
Loading

@rverma13927 please fill check box
and follow npx standard --fix
read CONTRIBUTING.md

use let in place of "var"
change file name according to rules
don't use ';'

@rverma13927
Copy link
Copy Markdown
Contributor Author

rverma13927 commented May 22, 2020

Please tell me it meets your requirement or not.

@itsvinayak
Copy link
Copy Markdown
Member

itsvinayak commented May 22, 2020

@rverma13927 thanks for contributing

@itsvinayak itsvinayak merged commit 735f173 into TheAlgorithms:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rverma13927 @itsvinayak
X Tutup