run: node .github/workflows/UpdateDirectory.js #167
Conversation
|
@sahilbansal17 Your review please... Your script seems to be doing its magic just fine! |
cclauss
changed the title
poyea
left a comment
poyea
left a comment
There was a problem hiding this comment.
Cool! It works. Just notice some extra issues when reviewing: there are 2 files on heapsort, maybe we have to change one of them to heapsort_2. Also, quickselect in the root should be in directory "search" or "algorithm".
|
@poyea Thanks for your review. The heap sort thing is covered in #164 where I am advocating that we have a benchmark that determines which implementation lives and which one dies. It is bugging me that we have a directory called algorithm because every submission to this repo should be an algorithm. We should move the files in that directory to other dirs that provide more specificity to what kind of algorithm it is. QuickSelect.js --> Search make sense to me. Linear-Algebra-Javascript should probably be renamed to Linear-Algebra. |
sahilbansal17
left a comment
sahilbansal17
left a comment
There was a problem hiding this comment.
I was not sure it was that easy :D
3 participants
Welcome to JavaScript community
Fixes #160