feat: add row echelon matrix algorithm#1454
Merged
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom Oct 11, 2023
Merged
feat: add row echelon matrix algorithm#1454raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom
Conversation
appgurueu
reviewed
Oct 9, 2023
appgurueu
reviewed
Oct 9, 2023
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
The decomposition into a set of properly named small functions makes this reasonably readable even without comments everywhere, though I suppose some comments wouldn't hurt. The doc comment needs to be moved to the proper function though, and the error case should throw. formatResult should be removed in favor of just using float tolerance in testing.
piyushk77
commented
Oct 10, 2023
Contributor
Author
piyushk77
left a comment
piyushk77
left a comment
There was a problem hiding this comment.
@appgurueu I have made the modifications. Have removed the formatResult and replaced it with isTolerant. Have changed the error cases to use throw instead of return. Also added the necessary comments wherever required.
appgurueu
approved these changes
Oct 10, 2023
raklaptudirm
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.