X Tutup
Skip to content

Fixes-the-Grammar-Mistake#1453

Merged
appgurueu merged 2 commits intoTheAlgorithms:masterfrom
Abhineshhh:GrammarError
Oct 7, 2023
Merged

Fixes-the-Grammar-Mistake#1453
appgurueu merged 2 commits intoTheAlgorithms:masterfrom
Abhineshhh:GrammarError

Conversation

@Abhineshhh
Copy link
Copy Markdown
Contributor

@Abhineshhh Abhineshhh commented Oct 5, 2023 •
edited
Loading

Describe your change:

pertrai1
pertrai1 reviewed Oct 5, 2023
View reviewed changes
@Abhineshhh
Copy link
Copy Markdown
Contributor Author

Abhineshhh commented Oct 6, 2023 •
edited
Loading

please review @raklaptudirm @appgurueu

appgurueu
appgurueu reviewed Oct 7, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting the Hacktoberfest website:

Avoid submitting low-quality pull/merge requests.

This is a fix for a typo in a comment. It doesn't affect the code or even the meaning of the comment at all. I'm afraid this pretty much makes it a textbook low quality contribution.

We do welcome chores like fixing typos, but please do them in bulk to reduce overhead, and don't expect them to count towards your Hacktoberfest score.

@appgurueu appgurueu added the hacktoberfest-invalid not eligible to count towards hacktoberfest points label Oct 7, 2023
@raklaptudirm
Copy link
Copy Markdown
Member

raklaptudirm commented Oct 7, 2023

@appgurueu Even though this can't be accepted for hacktoberfest please approve the changes so we can merge.

@Abhineshhh
Copy link
Copy Markdown
Contributor Author

Abhineshhh commented Oct 7, 2023 •
edited
Loading

sorry for inconvenience @appgurueu ! I am new to open source , i am in the learning period , next time this will not happen

@Abhineshhh
Copy link
Copy Markdown
Contributor Author

Abhineshhh commented Oct 7, 2023

hey @raklaptudirm merge this !!

@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Oct 7, 2023

sorry for inconvenience @appgurueu ! I am new to open source , i am in the learning period , next time this will not happen

That's fine. I suggest you to carefully reread the Hacktoberfest site to know the "rules" as a participant.

I will merge this for now (but I don't think it will count towards Hacktoberfest, given the label matching \binvalid\b), but in the future, please don't make PRs to fix single typos; it has way too much overhead. If you do decide to fix typos, fix multiple in one go.

@appgurueu appgurueu merged commit da0ee87 into TheAlgorithms:master Oct 7, 2023
@Abhineshhh Abhineshhh deleted the GrammarError branch October 7, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

+1 more reviewer

@pertrai1 pertrai1 pertrai1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-invalid not eligible to count towards hacktoberfest points

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[OTHER]: Grammar Mistake

4 participants

@Abhineshhh @raklaptudirm @appgurueu @pertrai1
X Tutup