feat: add MergeTwoSortedLinkedLIsts algorithms#1442
Merged
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom Oct 11, 2023
Merged
feat: add MergeTwoSortedLinkedLIsts algorithms#1442raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
Conversation
ahnge
changed the title
Contributor
Author
|
I'm participating in hacktoberfest. |
appgurueu
reviewed
Oct 9, 2023
appgurueu
requested changes
Oct 9, 2023
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
The class is unnecessary, this should be just the merge function.
(Note also that really, this "sorted merge" approach is more flexible: The proper abstraction is that of an iterator. This could then be an iterator merge taking two iterators and producing a merged one, which could be used to merge arrays, linked lists, doubly linked lists, whatever is iterable inorder and can be created inorder.)
change the function params and return value from Node to LinkedList.
appgurueu
approved these changes
Oct 10, 2023
raklaptudirm
approved these changes
Oct 11, 2023
Contributor
Author
|
Could you please label this pr as hacktoberfest? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.