New Algorithm: Parity Outlier#1314
Merged
raklaptudirm merged 10 commits intoTheAlgorithms:masterfrom May 1, 2023
Merged
Conversation
appgurueu
previously approved these changes
Apr 27, 2023
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
Looks fine, however:
- You could use
for-of. - There's no need to waste O(n) space. You can simply store the counts and the last element from both kinds.
appgurueu
reviewed
Apr 27, 2023
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
Please remove the "container" comment (and also the introduced redundant comments). Note that you can eliminate some elses since you already have early returns.
appgurueu
approved these changes
Apr 28, 2023
raklaptudirm
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.