X Tutup
Skip to content

algorithm: Project Euler Problem 44#1188

Merged
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
ddaniel27:patch-2
Oct 15, 2022
Merged

algorithm: Project Euler Problem 44#1188
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
ddaniel27:patch-2

Conversation

@ddaniel27
Copy link
Contributor

@ddaniel27 ddaniel27 commented Oct 14, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu requested changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests. You can get rid of the searching bool if you directly return the result.

@ddaniel27
Copy link
Contributor Author

ddaniel27 commented Oct 14, 2022

@appgurueu requested changes done! :)

appgurueu
appgurueu reviewed Oct 14, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 14, 2022
View reviewed changes
@raklaptudirm raklaptudirm changed the title [CREATE] Problem 044 from Project Euler algorithm: Project Euler Problem 44 Oct 15, 2022
@raklaptudirm raklaptudirm merged commit 148ebd6 into TheAlgorithms:master Oct 15, 2022
@ddaniel27 ddaniel27 deleted the patch-2 branch October 16, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddaniel27 @appgurueu @raklaptudirm
X Tutup