X Tutup
Skip to content

algorithm: SegmentTree#1178

Merged
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom
changicho:feature/segment-tree
Oct 20, 2022
Merged

algorithm: SegmentTree#1178
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom
changicho:feature/segment-tree

Conversation

@changicho
Copy link
Copy Markdown
Contributor

@changicho changicho commented Oct 13, 2022 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu reviewed Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant & clever implementation. Can you try to add more comments?

@changicho
Copy link
Copy Markdown
Contributor Author

changicho commented Oct 14, 2022

Elegant & clever implementation. Can you try to add more comments?

Sure! I add comments in new commit. Please check. Thanks.

@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Oct 14, 2022 •
edited
Loading

I was thinking of comments on the implementation details (e.g. how you store the binary tree in a list (same trick as heaps often use), how to calc. the parent pos. from a child pos. and vice versa).

@changicho
Copy link
Copy Markdown
Contributor Author

changicho commented Oct 14, 2022

I was thinking of comments on the implementation details (e.g. how you store the binary tree in a list (same trick as heaps often use), how to calc. the parent pos. from a child pos. and vice versa).

I add comments on the implementation details in new commit!

appgurueu
appgurueu reviewed Oct 14, 2022
View reviewed changes
appgurueu
appgurueu previously approved these changes Oct 14, 2022
View reviewed changes
@changicho
feat: Remove useless comment
2c3077a 
it duplicated by next line. so it is not necessary
@changicho changicho changed the title Create SegmentTree algorithm: SegmentTree Oct 15, 2022
@changicho
Copy link
Copy Markdown
Contributor Author

changicho commented Oct 18, 2022

@raklaptudirm Could you review this PR? 🙏

@raklaptudirm raklaptudirm merged commit 5867186 into TheAlgorithms:master Oct 20, 2022
@changicho changicho deleted the feature/segment-tree branch October 21, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@changicho @appgurueu @raklaptudirm
X Tutup