chore: add instruction for installing dependencies#1120
Merged
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom Oct 7, 2022
Merged
chore: add instruction for installing dependencies#1120raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
Conversation
…d test some codes and i found out that i needed to run and install jest from npm first, i did and it worked
Member
|
Seems unnecessary to me, you automatically install jest when you run npm install. |
appgurueu
requested changes
Oct 5, 2022
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
Please change this to recommend installation of all deps through npm install
Contributor
Author
Okay, I’ll do that. |
Contributor
Author
someone might not know he or she has to run the npm install, as a newbie, it was a challenge for me and i had it discovered to i thought it would be of clarification to other newbies. |
Contributor
Author
Alright thanks. |
appgurueu
approved these changes
Oct 6, 2022
raklaptudirm
approved these changes
Oct 7, 2022
raklaptudirm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d test some codes and i found out that i needed to run and install jest from npm first, i did and it worked
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.