Generalizing & Refactoring#411
Merged
christianbender merged 13 commits intoTheAlgorithms:masterfrom Apr 11, 2018
Merged
Conversation
Created utils methods Refactored ShellSort
Fixed the bugs in QuickSort Refactored QuickSort
Changes in InsertionSort and CountingSort
christianbender
requested changes
Apr 9, 2018
christianbender
left a comment
christianbender
left a comment
There was a problem hiding this comment.
Good Work! I have some requests
Sorts/src/sort/BogoSort.java
Outdated
| * @see SortAlgorithm | ||
| * | ||
| */ | ||
| public class BogoSort implements SortAlgorithm{ |
There was a problem hiding this comment.
Please add space between the interface name and the curly brace.
Sorts/src/sort/BubbleSort.java
Outdated
| * @see SortAlgorithm | ||
| */ | ||
|
|
||
| class BubbleSort implements SortAlgorithm{ |
Contributor
Author
|
Done |
Contributor
Author
|
Added the new algorithms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was too many differences in code between sort classes, so I decided to generalize it.
I've created utility class which removes some boilerplate and the general interface for the most algorithms
Also, I replaced all algorithms in a new directory, like others java projects
Fixed some bugs in the algorithms and did some perfomance improvments