A few improvments of counting sort#409
Merged
christianbender merged 2 commits intoTheAlgorithms:masterfrom Apr 9, 2018
Merged
Conversation
Changed the original sorting method: creating and throwing an exception it costs then using getOrDefault for a map
christianbender
requested changes
Apr 8, 2018
christianbender
left a comment
christianbender
left a comment
There was a problem hiding this comment.
Good Work! I have some requests
Sorts/CountingSort.java
Outdated
|
|
||
| // Filling the sortedArray | ||
| for(Map.Entry<T, Integer> element : frequency.entrySet()) { | ||
| public static <T extends Comparable<T>> List<T> CS(List<T> list) { |
There was a problem hiding this comment.
Please change the name of the method according to naming conventions in java.
Sorts/CountingSort.java
Outdated
|
|
||
| // Filling the sortedArray | ||
| for(Map.Entry<T, Integer> element : frequency.entrySet()) { | ||
| for(int j=0; j<element.getValue(); j++) |
Added curly braces for the loop
Contributor
Author
|
Great! I've fulfilled your requests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the counting sort method which uses stream API
Changed the original sorting method: creating and throwing an exception it costs much more then using getOrDefault for a map