X Tutup
Skip to content

Add Hexadecimal to Octal#316

Merged
varunu28 merged 4 commits intoTheAlgorithms:masterfrom
The-TJ:patch-1
Dec 6, 2017
Merged

Add Hexadecimal to Octal#316
varunu28 merged 4 commits intoTheAlgorithms:masterfrom
The-TJ:patch-1

Conversation

@The-TJ
Copy link
Copy Markdown
Contributor

@The-TJ The-TJ commented Nov 17, 2017

Program that converts Hexadecimal numbers to Octal.

Program that converts Hexadecimal numbers to decimal.
@The-TJ The-TJ changed the title Create HextoDec.java Added Hexadecimal to Decimal Nov 18, 2017
Copy link
Copy Markdown
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Enter comments for your function to give description of what the function is actually doing and what are the parameters and return value

@The-TJ The-TJ changed the title Added Hexadecimal to Decimal Add Hexadecimal to Octal Nov 22, 2017
@The-TJ
Copy link
Copy Markdown
Contributor Author

The-TJ commented Nov 22, 2017

The comments have been added. Thanks for reviewing the code!

Copy link
Copy Markdown
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Keep the main method for input and the final output
  • Create another function for Octal conversion
  • Add proper conventions for comments. Refer InsertionSort under sorts for conventions

@The-TJ
Copy link
Copy Markdown
Contributor Author

The-TJ commented Nov 26, 2017

All the changes have been made. Please check the code now. Thank you very much for your time!

@The-TJ
Copy link
Copy Markdown
Contributor Author

The-TJ commented Dec 6, 2017

Hey Varunu. Do need to make any other changes or this is grand as it is?

@varunu28 varunu28 merged commit 6efaddb into TheAlgorithms:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup