Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6475 +/- ##
==========================================
+ Coverage 95.89% 95.90% +0.01%
==========================================
Files 844 845 +1
Lines 266044 265932 -112
==========================================
- Hits 255114 255042 -72
+ Misses 10930 10890 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Vulkan GPU shader implementation for the cumulative sum operation, enabling hardware-accelerated prefix sum computation across different tensor dimensions.
Key changes:
- Implements three-pass algorithm: block-level scan, block sums scan, and offset addition
- Supports 1D, 2D, and 3D tensors with axis selection
- Uses Kogge-Stone parallel scan algorithm with 256-element work groups
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/layer/vulkan/shader/cumulativesum_blockscan.comp | First pass shader that performs prefix scan within 256-element blocks |
| src/layer/vulkan/shader/cumulativesum_blocksums_scan.comp | Second pass shader that scans the block sums to compute offsets |
| src/layer/vulkan/shader/cumulativesum_addoffset.comp | Third pass shader that adds block offsets to complete the cumulative sum |
| src/layer/vulkan/cumulativesum_vulkan.h | Header declaring the Vulkan implementation class with three pipeline stages |
| src/layer/vulkan/cumulativesum_vulkan.cpp | Implementation managing pipeline creation and multi-pass execution strategy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.