chore(prowlarr): Remove FlareSolverr warning#2599
Open
csandman wants to merge 1 commit intoTRaSH-Guides:masterfrom
Open
chore(prowlarr): Remove FlareSolverr warning#2599csandman wants to merge 1 commit intoTRaSH-Guides:masterfrom
csandman wants to merge 1 commit intoTRaSH-Guides:masterfrom
Conversation
Remove the warning that FlareSolverr is non-functional, as it currently is functioning fine.
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Prowlarr FlareSolverr setup documentation by removing an outdated bug warning that stated FlareSolverr was non-functional and unlikely to be fixed, reflecting that the issue has been resolved and the tool is working again. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
github-actions
bot
added
Area: Backend
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `docs/Prowlarr/prowlarr-setup-flaresolverr.md:13` </location>
<code_context>
-
## Install FlareSolverr
Please follow the installation instruction from [FlareSolverr](https://github.com/FlareSolverr/FlareSolverr#installation){:target="\_blank" rel="noopener noreferrer"}
</code_context>
<issue_to_address>
**issue (typo):** Use 'instructions' instead of 'instruction' for correct grammar.
This aligns with referring to a set of steps from FlareSolverr.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| ## Install FlareSolverr | ||
|
|
||
| Please follow the installation instruction from [FlareSolverr](https://github.com/FlareSolverr/FlareSolverr#installation){:target="\_blank" rel="noopener noreferrer"} |
Contributor
There was a problem hiding this comment.
issue (typo): Use 'instructions' instead of 'instruction' for correct grammar.
This aligns with referring to a set of steps from FlareSolverr.
Contributor
|
Deploying with ⚡ Cloudflare Pages
|
Contributor
|
Removing it isn't the correct way because Cloudflare has been known to actively break tools like this, so your luck may vary. So let me come up with a better suggestion in a few minutes @csandman I added a few suggestions you can include in the PR. Once that's done, I'm willing to review and approve it. Just add all three suggestions to a batch using "Add suggestion to batch," and then you can merge all three at once |
Contributor
TRaSH-
added
the
Status: Waiting for User
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Purpose
I saw the warning about FlareSolverr being non-functional, but after checking the issue linked in the message (FlareSolverr/FlareSolverr#1253), it appears that it has been fixed. Also, after testing myself I can confirm that FlareSolverr is now working as expected. So, I figure that this warning is now misleading, and should be removed so people don't automatically give up on FlareSolverr as a potential solution.
Sorry if I didn't set this PR up correctly, I can adjust it if that's preferred.
Requirements
Summary by Sourcery
Documentation: