Style patching tree node (issue #42)#57
Open
Samuel-IH wants to merge 2 commits intoSwiftWebUI:developfrom
Open
Style patching tree node (issue #42)#57Samuel-IH wants to merge 2 commits intoSwiftWebUI:developfrom
Samuel-IH wants to merge 2 commits intoSwiftWebUI:developfrom
Conversation
SwiftWebUI#42 (cherry picked from commit 777e1bb)
…TMLStylePatchingNode` Now what do we do with HTMLShadowNode and HTMLBackgroundNode? (cherry picked from commit 91e34b6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I have taken a recent interest in this project and have written a PR for issue #42
The idea of HTMLStylePatching node is to serve as a "container" to hold style patches, whenever we call the
.patchfunction it will automatically hook into an existing patching node, or create a new one if it doesn't already exist.The sample code presented in #42 works properly now, however, I am still having minor issues chaining multiple shadows on the same view (CSS shadow blending issues).
Lastly, I would like to note that my implementation in BackgroundModifier.swift isn't as clean as I wish (I had to copy the style switch from the HTML node). Perhaps there is a better way to do this.