X Tutup
Skip to content

95 Don't assume Interval >> #sorted returns a new object #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbrichau merged 1 commit into from
Aug 29, 2019
Merged

95 Don't assume Interval >> #sorted returns a new object #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...-Tests-Core.package/GRCollectionTest.class/instance/assert.validSequencedResponseFrom..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
asserting
assert: responseCollection validSequencedResponseFrom: receiverCollection
"Assert that the returned object is of a valid response class for the tested collection."

self assert: (self isValidNewSequencedResponseClass: responseCollection class)
12 changes: 12 additions & 0 deletions repository/Grease-Tests-Core.package/GRIntervalTest.class/instance/testSorted.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
tests
testSorted
"Unlike super implementation do not assume Interval >> #sorted returns a new object"
| sorted collection |
collection := self arbitraryCollection.
sorted := collection sorted.
self assert: sorted validSequencedResponseFrom: collection.
self assert: sorted sortedWith: [ :a :b | a <= b ].

sorted := collection sorted: [ :a :b | a > b ].
self assert: sorted validSequencedNewResponseFrom: collection.
self assert: sorted sortedWith: [ :a :b | a > b ]
X Tutup