92-Pharo-baseline-can-be-factorized#93
Merged
jbrichau merged 1 commit intoSeasideSt:masterfrom Jun 17, 2019
Merged
Conversation
Member
Author
|
@jbrichau Checks passed, it just needs a review now :) |
Member
|
@jecisc Yes, I wanted to check it asap. Will do. |
jbrichau
approved these changes
Jun 11, 2019
Member
jbrichau
left a comment
jbrichau
left a comment
There was a problem hiding this comment.
They seem fine, but I would expect the packages Grease-Core and Grease-Tests-Core to be listed in the pharo section with more specific sections adding their requires and includes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factorize baseline of pharo.
Fixes #92