Fix macroman encoding lookup#71
Conversation
|
@theseion Hi Max, it seems a lot of files are changed in this PR? I think it's better to redo against master. |
|
@theseion Ok, did not know I could that myself :) |
|
I'm still a bit confused. The change is in the |
|
I see that I messed that up. Let me redo the PR. |
42fc001 to
607d7ae
Compare
|
I've made the same change but this time to Squeak5-Core, Squeak6-Core, and Pharo7-Core. As for Pharo20-Core, that indeed isn't being loaded in Squeak but is in Pharo 7. I had made the change in a text editor and hadn't realised that there were multiple implementations in different packages. |
|
Arrgh! Looks like I accidentally committed metadataless, which breaks the Pharo3 build 😠 |
Put back methodProperties.json and version files (required for Pharo 3 build)
|
Ok, this works now. |
|
Looks good! Thanks! |
No description provided.