Conversation
|
Best hold-off merging this pull request until I know how to initialize the Latin1ToUtf8Encodings classvars on loading of the new version... |
|
Presumably we could turn that into a class var? |
|
Yes, issue #3 was integrated as well (no global, only a classvar) but it needs to be initialized too. |
|
... I guess I didn't actually look at code:) ... Dale, step away from the pull request:) |
|
aha:) Well, I added a postLoadDoit: to the baseline, which I guess should work. I was holding off the integration until I get a second look at my code and until I got to the test the initialization code by doing an upgrade of Grease. |
|
Well.. "my code" is a bad word, I just copy/pasted your code. But I wanted to see if I should write additional tests. |
|
Haha, my code was copied and pasted from @obi068:) On Mon, Oct 20, 2014 at 10:12 AM, Johan Brichau notifications@github.com
|
|
Ok, so it seems because of the class change to another package, that the class var is initialized. |
No description provided.