X Tutup
Skip to content

Dev 1.1.12#7

Merged
jbrichau merged 9 commits intomasterfrom
dev-1.1.12
Nov 8, 2014
Merged

Dev 1.1.12#7
jbrichau merged 9 commits intomasterfrom
dev-1.1.12

Conversation

@jbrichau
Copy link
Member

No description provided.

@jbrichau
Copy link
Member Author

Best hold-off merging this pull request until I know how to initialize the Latin1ToUtf8Encodings classvars on loading of the new version...

@dalehenrich
Copy link
Member

Presumably we could turn that into a class var?

@jbrichau
Copy link
Member Author

Yes, issue #3 was integrated as well (no global, only a classvar) but it needs to be initialized too.

@dalehenrich
Copy link
Member

... I guess I didn't actually look at code:) ... Dale, step away from the pull request:)

@jbrichau
Copy link
Member Author

aha:) Well, I added a postLoadDoit: to the baseline, which I guess should work. I was holding off the integration until I get a second look at my code and until I got to the test the initialization code by doing an upgrade of Grease.

@jbrichau
Copy link
Member Author

Well.. "my code" is a bad word, I just copy/pasted your code. But I wanted to see if I should write additional tests.

@dalehenrich
Copy link
Member

Haha, my code was copied and pasted from @obi068:)

On Mon, Oct 20, 2014 at 10:12 AM, Johan Brichau notifications@github.com
wrote:

Well.. "my code" is a bad word, I just copy/pasted your code. But I wanted
to see if I should write additional tests.


Reply to this email directly or view it on GitHub
GsDevKit#7 (comment).

@jbrichau
Copy link
Member Author

jbrichau commented Nov 8, 2014

Ok, so it seems because of the class change to another package, that the class var is initialized.

jbrichau pushed a commit that referenced this pull request Nov 8, 2014
@jbrichau jbrichau merged commit 00a7df6 into master Nov 8, 2014
@jbrichau jbrichau deleted the dev-1.1.12 branch November 8, 2014 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup