X Tutup
Skip to content

added GRDynamicVariable#23

Closed
theseion wants to merge 1 commit intoSeasideSt:devfrom
theseion:dev
Closed

added GRDynamicVariable#23
theseion wants to merge 1 commit intoSeasideSt:devfrom
theseion:dev

Conversation

@theseion
Copy link
Member

  • added GRDynamicVariable
  • added tests for GRDynamicVariable

* added tests for GRDynamicVariable
@jbrichau
Copy link
Member

Hey Max,

As mentioned, thanks for doing this. This is much appreciated.
I notice the tests for Squeak and Gemstone are failing. Should they be working or is this not yet implemented for those platforms?

@theseion
Copy link
Member Author

I've only implemented the change for Pharo so far as I wasn't sure wether what I have done fits the way Grease and Seaside play together on the different platforms. If you think the change is fine I'll happily contribute the change for Squeak. I don't have access to / experience with Gemstone, so I'd be glad if somebody else could make the change for Gemstone. I do have access to VW and VASt so I could try to make those changes myself.

@jbrichau
Copy link
Member

Hi Max,

I took a look at the changes and created a different branch so I can fix the merge issues and take a look at the gemstone stuff. I propose to close this pull request and continue development on that branch together. What do you think?

https://github.com/SeasideSt/Grease/tree/pull23_dev

@theseion
Copy link
Member Author

Sure, let's do that.

@theseion theseion closed this May 25, 2017
@theseion theseion deleted the dev branch May 25, 2017 12:44
jbrichau pushed a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup