Identifying on which platform is Grease running#190
Identifying on which platform is Grease running#190jbrichau merged 1 commit intoSeasideSt:masterfrom
Conversation
b5914e7 to
26f6af4
Compare
|
We're trying to avoid this kind of method but I do acknowledge that it is often very handy to have. So, let's add it to Grease. However, Grease is also on the Squeak and VAST platforms (the code for the last one is not in this repo, but it exists). So I would prefer to list all supported platforms. Doing the check in this way means it will break silently when a class name changes. Although unlikely, I would like to recommend an implementation as follows: GRPlatform>>#isGemStone, GRPlatform>>#isPharo, GRPlatform>>#isSqueak, GRPlatform>>#isVAST GRPharoPlatform>>#isPharo GRGemStonePlatform>>#isGemStone GRGemStonePlatformTest>>testIsGemStone The important thing here is that if we add it to Grease, it is expected to exist on all platforms and work. So, a test on each platform will need to be added. |
26f6af4 to
8ebbf69
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 86.78% 86.79%
=======================================
Files 1860 1869 +9
Lines 12797 12840 +43
=======================================
+ Hits 11106 11144 +38
- Misses 1691 1696 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Funny is that my first/second commit was similar to what you wanted. I wanted to reduce the number of methods so I got fancy :). I have created the patch in a way that should now work for everyone. I have also send PR for the information which dialects are consuming Grease. |
850a312 to
9739fc2
Compare
2c846f1 to
c159455
Compare
c159455 to
2d98f90
Compare
|
@jbrichau The failing test |
|
I lost track of this PR. Merging it now |
Adding a platform testing code. It will make life easier for Magritte testing.