Expanded the testcase for GRPlatform>>secureHashFor:#182
Merged
Conversation
…y as argument since this method is used in Seaside with any String or ByteArray
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 85.58% 85.59% +0.01%
==========================================
Files 2050 2050
Lines 14100 14110 +10
==========================================
+ Hits 12067 12077 +10
Misses 2033 2033 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
GRPlatform>>secureHashFor:accepts both aStringand aByteArrayas argument. The contents of theByteArraycan be any sequence of bytes, so it should not represent a valid UTF8 encodedString(for example).In this PR, we extend the test case to also cover the use of a
ByteArray.In Seaside, all invocations of the method always passed a
Stringinstance as argument, until the e-tag implementation for the file libraries, which also uses it to generate a hash for any served file, which may include binary files (e.g. images). See SeasideSt/Seaside#1325.