Avoid copies in GRPharoZnCodecStream#144
Merged
jbrichau merged 2 commits intoSeasideSt:masterfrom Sep 1, 2022
Merged
Conversation
Contributor
Author
|
I only added Pharo 9.0 and 10.0 implementations. Others could probably be added as well if someone checks whether the built-in Zinc version implements the methods. |
jbrichau
requested changes
Aug 26, 2022
Member
jbrichau
left a comment
jbrichau
left a comment
There was a problem hiding this comment.
I have not had the chance this week to re-check why the asString was needed in the use of the encoder in the WAUrlEncoder and if it could be solved more elegantly. I remember from when I made the changes to use the ZnUTF8Encoder in Pharo, this popped up as something I could only solve with sending the asString but I was not really happy about it.
Perhaps you have some ideas for a better solution?
repository/Grease-Pharo100-Core.package/GRPharoZnCodecStream.class/instance/nextPutAll..st
Outdated
Show resolved
Hide resolved
marschall
force-pushed
the
GRPharoZnCodecStream-nextPutAll
branch
from
7fead69 to
c75b7d4
Compare
jbrichau
approved these changes
Sep 1, 2022
jbrichau
pushed a commit
to SeasideSt/Seaside
that referenced
this pull request
Sep 4, 2022
Bump Seaside version as well (preparing for new release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143