X Tutup
Skip to content

Add #asMethodReturningString:named: #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marschall merged 2 commits into from
Aug 25, 2022
Merged

Add #asMethodReturningString:named: #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c167c8d
Add #asMethodReturningString:named:
marschall Aug 21, 2022
3e48c6c
Add unit tests for string methods
marschall Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions repository/Grease-Core.package/GRPlatform.class/instance/asMethodReturningString.named..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
file library
asMethodReturningString: aByteArrayOrString named: aSymbol
"Generates the source of a method named aSymbol that returns aByteArrayOrString as a String.

This implementation answers a String formatted like so

aSymbol
^ aByteArrayOrString

Subclasses need to override this method if the dialect needs changes to support Unicode string literals"
^ String streamContents: [ :stream |
stream
nextPutAll: aSymbol;
nextPut: Character cr.
stream
tab;
nextPutAll: '^ '''.
aByteArrayOrString greaseString do: [ :each |
each = $' ifTrue: [ stream nextPut: $' ].
stream nextPut: each ].
stream nextPut: $' ]
4 changes: 4 additions & 0 deletions repository/Grease-Core.package/GRPlatform.class/instance/doSilently..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
file library
doSilently: aBlock
"Suspend all notifications value evaluating the given block."
^ aBlock value
3 changes: 3 additions & 0 deletions repository/Grease-Tests-Core.package/GRPlatformTest.class/instance/runCase.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
running
runCase
GRPlatform current doSilently: [ super runCase ]
10 changes: 10 additions & 0 deletions repository/Grease-Tests-Core.package/GRPlatformTest.class/instance/supportsUnicode.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
private
supportsUnicode
"dynamically try to figure out whether the current dialect supports Unicode"
^ [
String
with: (Character value: 16r1F1F3)
with: (Character value: 16r1F1F1).
true
] on: Error
do: [ :error | false ]
17 changes: 17 additions & 0 deletions repository/Grease-Tests-Core.package/GRPlatformTest.class/instance/testCompileAsciiString.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
tests-file library
testCompileAsciiString
| selector expected source |

self supportsUnicode ifFalse: [
^ self ].

selector := #stringMethod.
expected := 'test ok'.
source := GRPlatform current asMethodReturningString: expected named: selector.
[
| actual |
GRPlatform current compile: source into: self class classified: 'private'.
actual := self perform: selector.
self assert: expected = actual
] ensure: [
GRPlatform current removeSelector: #stringMethod from: self class ]
15 changes: 15 additions & 0 deletions ...itory/Grease-Tests-Core.package/GRPlatformTest.class/instance/testCompileUnicodeString.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
tests-file library
testCompileUnicodeString
| selector expected source |
selector := #stringMethod.
expected := String
with: (Character value: 16r1F1F3)
with: (Character value: 16r1F1F1).
source := GRPlatform current asMethodReturningString: expected named: selector.
[
| actual |
GRPlatform current compile: source into: self class classified: 'private'.
actual := self perform: selector.
self assert: expected = actual
] ensure: [
GRPlatform current removeSelector: #stringMethod from: self class ]
X Tutup