X Tutup
Skip to content

Treat text files as utf8 encoded rather than ascii (in Pharo only for now) #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbrichau merged 5 commits into from
Aug 16, 2021
Merged

Treat text files as utf8 encoded rather than ascii (in Pharo only for now) #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1397779
Change ascii to utf8 encoding for text files in Pharo 9
Aug 15, 2021
652acb5
Change ascii to utf8 encoding for text files in Pharo 7
Aug 16, 2021
d305fd5
Move utf8 test file read/write test to Pharo specific test package an…
Aug 16, 2021
eee0956
Fixed wrong version comparison for expected failure in test
Aug 16, 2021
4ab1beb
Seems like the MultiByteFileStream did write utf8 already... (so this…
Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Grease-Pharo70-Core.package/GRPharoPlatform.class/instance/readFileStreamOn.do.binary..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ readFileStreamOn: aString do: aBlock binary: aBoolean

^ aBoolean
ifTrue: [ aString asFileReference binaryReadStreamDo: aBlock ]
ifFalse: [ aString asFileReference readStreamEncoded: 'ascii' do: aBlock ]
ifFalse: [ aString asFileReference readStreamEncoded: 'utf-8' do: aBlock ]
2 changes: 1 addition & 1 deletion ...rease-Pharo70-Core.package/GRPharoPlatform.class/instance/writeFileStreamOn.do.binary..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ file library
writeFileStreamOn: aString do: aBlock binary: aBoolean
^ aBoolean
ifTrue: [ aString asFileReference binaryWriteStreamDo: aBlock ]
ifFalse: [ aString asFileReference writeStreamEncoded: 'ascii' do: aBlock ]
ifFalse: [ aString asFileReference writeStreamEncoded: 'utf-8' do: aBlock ]
2 changes: 1 addition & 1 deletion ...Grease-Pharo90-Core.package/GRPharoPlatform.class/instance/readFileStreamOn.do.binary..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ readFileStreamOn: aString do: aBlock binary: aBoolean

^ aBoolean
ifTrue: [ aString asFileReference binaryReadStreamDo: aBlock ]
ifFalse: [ aString asFileReference readStreamEncoded: 'ascii' do: aBlock ]
ifFalse: [ aString asFileReference readStreamEncoded: 'utf-8' do: aBlock ]
2 changes: 1 addition & 1 deletion ...rease-Pharo90-Core.package/GRPharoPlatform.class/instance/writeFileStreamOn.do.binary..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ file library
writeFileStreamOn: aString do: aBlock binary: aBoolean
^ aBoolean
ifTrue: [ aString asFileReference binaryWriteStreamDo: aBlock ]
ifFalse: [ aString asFileReference writeStreamEncoded: 'ascii' do: [ :str | aBlock value: (ZnNewLineWriterStream on: str) ] ]
ifFalse: [ aString asFileReference writeStreamEncoded: 'utf-8' do: [ :str | aBlock value: (ZnNewLineWriterStream on: str) ] ]
7 changes: 7 additions & 0 deletions ...ro-Core.package/GRPharoPlatformTest.class/instance/testReadWriteToFileInFolderTextUTF8.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
tests-filestreams
testReadWriteToFileInFolderTextUTF8
#('Übèrstrîñgé' '£ęλ~') do:[ :text |
self
writeToFile: text
withFileNameDo:[ :fileName |
self assert: text equals: (GRPlatform current contentsOfFile: fileName binary: false) ] ].
X Tutup