X Tutup
Skip to content

Fix reading contents of empty binary file #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbrichau merged 1 commit into from
Jul 31, 2020
Merged

Fix reading contents of empty binary file #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...tory/Grease-Pharo70-Core.package/GRPharoPlatform.class/instance/contentsOfFile.binary..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
file library
contentsOfFile: aString binary: aBoolean
^ self fileStreamOn: aString do: [ :stream | stream contents ] binary: aBoolean
^ aBoolean
ifTrue:[ self fileStreamOn: aString do: [ :stream | stream contents ifNil:[ ByteArray new ] ] binary: aBoolean ]
ifFalse:[ self fileStreamOn: aString do: [ :stream | stream contents ] binary: aBoolean ]
8 changes: 8 additions & 0 deletions ...-Tests-Core.package/GRPlatformTest.class/instance/testReadWriteEmptyFileInFolderBinary.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
tests-filestreams
testReadWriteEmptyFileInFolderBinary
| bytes |
bytes := ByteArray new.
self
writeToFile: bytes
withFileNameDo:[ :fileName |
self assert: (bytes = (GRPlatform current contentsOfFile: fileName binary: true)) ]
8 changes: 8 additions & 0 deletions ...se-Tests-Core.package/GRPlatformTest.class/instance/testReadWriteEmptyFileInFolderText.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
tests-filestreams
testReadWriteEmptyFileInFolderText
| text |
text := String new.
self
writeToFile: text
withFileNameDo:[ :fileName |
self assert: (text = (GRPlatform current contentsOfFile: fileName binary: false)) ]
X Tutup