Conversation
added 12 commits
May 17, 2020 14:25
… monticello metadata)
theseion
reviewed
May 21, 2020
repository/BaselineOfGrease.package/BaselineOfGrease.class/instance/baselinePharo..st
Show resolved
Hide resolved
theseion
approved these changes
May 21, 2020
Member
theseion
left a comment
theseion
left a comment
There was a problem hiding this comment.
Looks good to me. Just to clarify, you added #greaseAsMutator but haven't used it anywhere yet, right? Will that require an additional PR for Seaside?
Member
Author
Yes, It's in SeasideSt/Seaside#1195 to change Seaside once this Grease version is published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Pragma>>keywordis replaced withPragma>>selector.Symbol>>asMutator. I created the methodgreaseAsMutatoras a Grease alternative to the platform-specificasMutatorand added implementations on all supported platforms.