X Tutup
Skip to content

Replace 'ascii' encoding for non-binary files with 'utf-8' encoding  #122

@jbrichau

Description

@jbrichau

There is a distinction between text and binary files in the filestream methods of Grease. Text files are considered to use the 'ascii' encoding when reading/writing them in Grease. However, text files are nowadays commonly using/requiring utf8 encoding. See issue in SeasideSt/Seaside#1273

It's probably acceptable to use utf8 for text files because:

  • utf8 is backwards compatible with ascii encoding
  • Pharo uses utf8 for internal string encoding

Leaves me with the quibble that utf8 encoded files are actually binary files, so this difference between 'text' and 'binary' files leaves me wondering if this still makes sense...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      X Tutup