X Tutup
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: javascript-tutorial/en.javascript.info
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: SastraNababan/javascript-tutorial-id
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1,617 files changed
  • 1 contributor

Commits on Oct 12, 2019

  1. sync (#1)

    * closes #1220
    
    * Update MDN docs link for tagged templates
    
    * Update article.md
    
    As per issue comment thread #1282: 
    Clarifying "current code" for zero delay setInterval. 
    Plus minor edit of ordering of terms for greater consistency.
    Plus minor grammatical fixes.
    
    * an -> a
    
    * WIP
    
    * fixes #1316
    
    * closes #1318
    
    * minor
    
    * minor
    
    * WIP
    
    * WIP
    
    * regexp
    
    * WIP
    
    * reg->regexp
    
    * WIP
    
    * Typo fix
    
    * minor
    
    * form
    
    * Typo fix
    
    * fixes
    
    * fixes
    
    * fix
    
    * Fix minor grammatical errors
    
    * Minor grammatical fixes
    
    * minor
    
    * Update h to H char according ASCII value 
    
    I have found that ASCII is not matching with char h so I have a changed.
    
    h = 104
    H = 72
    
    * closes #1327
    
    * minor
    
    * minor
    
    * Minor grammar fix
    
    "People adore to use things" -> "People adore using things"
    
    * Minor grammar fix
    
    Remove extra "of" from "a thousand other reasons"
    
    * Typo fix
    
    "shorter named" -> "shorter names"
    
    * Update article.md
    
    Minor wording changes.
    
    * Update solution.md
    
    Wording change. (I actually like the original wording "does not give understanding" -- very concise, and communicates clearly. It's just a bit non-standard in usage).
    
    * Update article.md
    
    Minor wording change.
    
    * Typo fix
    
    "agains" -> "against"
    
    * Minor grammar fix
    
    'cookie'(as object of this sentence) seems losing.
    
    * Update article.md
    
    Wording and punctuation of 'hasOwnProperty' 'for..in' loop question and answer.
    
    * Update article.md
    
    Wording adjustments in Summary lines "- Write/delete...", and "- The `for..in`...".
    
    * Update solution.md
    
    "avoid" rather than "evade".
    
    * Update task.md
    
    Wording / punctuation change.
    
    * Update article.md
    
    Remove comma.
    
    * Corrected typos
    
    * Update article.md
    
    Wording on internal name and Function Declarations.
    
    * Update article.md
    
    Wording change on intro to "Accessor descriptors".
    
    * Update article.md
    
    Change "and" to "or". Goes better with "no".
    
    * Update article.md
    
    * Various minor grammar fixes and improvements
    
    Mostly adding "the" as necessary; typo fixes; some word order in clauses changed or contractions used for for smoothness
    
    * Fix typo
    
    * Fix typo
    
    * Fix typo
    
    * Update article.md
    
    Adding "an". Making subject of second clause explicit (not necessary, but may improve readability).
    
    * Update article.md
    
    Adding 'is'.
    
    * Update article.md
    
    Added commas. "Later in the year" without commas at first suggests "later that same year" or "in the later part of the year" (like, say Autumn). It's clear from the context and all, but it reads easier this way.
    
    * Update article.md
    
    to that -> for this
    
    * Update article.md
    
    The ol' evade -> avoid.
    
    * Update article.md
    
    Various small word and punctuation changes.
    
    * Fix extending of class
    
    * fix
    
    * fix
    
    * fix
    
    * Update article.md
    
    Change "you'd" to "you'll".
    
    * Update solution.md
    
    "themselves" instead of "itself".
    
    * Update article.md
    
    fixed a typo
    
    * fix
    
    * Typo fixes
    
    * typo
    
    * Update article.md
    
    * Update article.md
    
    Add "the" before "'this' keyword".
    
    * Spell correction
    
    Changed hid -> hide
    
    * closes #1377
    
    * fixes #1369
    
    * Update article.md
    
    VS code is a very common editor; especially for JavaScript.
    
    * Update two article.md files
    
    Recently you removed `e.g. Python` but forgot `like`.
    Corrected `prototypally` to `prototypically`.
    
    * Fixed typos
    
    * Update solution.md
    
    Change "so to say" to "so to speak".
    
    * minor
    
    * Fix typos in "Blob"
    
    Fixed minor grammatical errors in **Blob** lesson in the chapter **Binary data, files**.
    
    * Typo fixed in "Function expressions and arrows"
    
    * Update article.md
    
    Wording changes to 2012 prototype history. "allowed to" without a "who" is not very grammatical. Could replace with "allowed us to" or "allowed the user to". I went with a different verb, but either of the others would be OK too.
    
    Also a little punctuation change to 2015 history.
    
    * Update article.md
    
    Change 'just as' to 'just like'.
    
    * Update article.md
    
    Adjustments to line about class properties. Add "the", change "the" to "a".
    
    * Update article.md
    
    Change spelling of "labelled" to "labeled". "Labelled" is British spelling, "labeled" is American. I hadn't noticed British spelling being used in general so thought it should probably be the American version.
    
    * Update article.md
    
    "by the way" -> "along the way"
    
    * Update article.md
    
    * Update cloning algorithm URL
    
    Url was pointing to a broken page, updated to match the working URL.
    
    * minor
    
    * minor
    
    * Update article.md
    
    * minor
    
    * minor
    
    * Update article.md
    
    Change "Although" to "Still". Reads a bit better.
    
    * Update article.md
    
    Added "And".
    
    * Update article.md
    
    "to" tweak, no comma.
    
    * minor
    
    * closes #1399
    
    * minor
    
    * closes #1387
    
    * typo
    
    sTomething - > something
    
    * fixes #1395
    
    * Minor fixes for consistency
    
    * Minor grammar fixes
    
    Some capitalization, punctuation, articles
    
    * Update article.md
    
    * Fix grammatical errors
    
    * Update article.md
    
    Replace 'cause' with 'case'.
    
    * Update article.md
    
    Give results of 'alert' ('true') rather than description of method. Code seems pretty self-explanatory.
    
    * Update article.md
    
    Replaced 'the ... property ... works since" with "the ... property ... has worked since".
    
    * Update article.md
    
    Replaced ":"s with ","s. 
    
    I edited these lines before, and thought they were a little awkward w/ ":"s, but didn't see fit to change it then. But now ","s seem clearly better. Think of it as successive approximations.
    
    * Update article.md
    
    Add results of 2nd alert
    
    * Update article.md
    
    object constructor -> the object's constructor
    
    * Update article.md
    
    'chapter' -> 'article'
    
    * Remove unnecessary code syntax inside buttons
    
    * Update article.md
    
    and -> or, methods -> methods
    
    I also have a question on the subject of this sentence (should this be a separate discussion entry?):
    In the "Extending built-in classes" article, in the "No static inheritance in built-ins" subsection, one finds:
    
    "But built-in classes are an exception. They don’t inherit statics from each other.
    
    For example, both Array and Date inherit from Object, so their instances have methods from Object.prototype. But Array.[[Prototype]] does not reference Object, so there’s no Array.keys() and Date.keys() static methods."
    
    In the "Extending built-in classes" article, in the "No static inheritance in built-ins" subsection, one finds:
    
    "But built-in classes are an exception. They don’t inherit statics from each other.
    
    For example, both Array and Date inherit from <code>Object</code>, so their instances have methods from <code>Object.prototype</code>. But <code>Array.[[Prototype]]</code> does not reference <code>Object</code>, so there’s no <code>Array.keys()</code> and <code>Date.keys()</code> static methods."
    
    This is a subject of some curiosity for me. Through a little testing, I believe I have found that, in fact <code>Array.[[Prototype]]</code> DOES, however, reference <code>Function.prototype</code>, i.e. <code>Array.__proto__ === Function.prototype</code> (<code>true</code>). (As does <code>Date.[[Prototype]]</code>). Is there someplace where this is explained? (Preferably in a way an intelligent 11-year-old could understand?).
    
    * Update article.md
    
    'That's funny' -> 'It's funny'
    
    * Fix minor typos in Server Sent Events lesson
    
    * minor
    
    * Fixed typo on line 366
    
    "Now when the call looks for `count` variable, it first searches its own Lexical Environment (empty), then the Lexical Environment of the outer `makeCounter()` call, where finds it."
    
    to
     
    "Now when the call looks for `count` variable, it first searches its own Lexical Environment (empty), then the Lexical Environment of the outer `makeCounter()` call, where it finds it."
    
    * Update article.md
    
    * Update article.md
    
    Events is -> Events are
    
    * Update article.md
    
    allows to -> allows us to
    
    * Update article.md
    
    listen to -> listen for
    some punctuation, little words
    
    * Update article.md
    
    Summary -- adding 'adding' and 'happening'.
    
    * Update article.md
    
    Added 'Oxford comma" (comma before 'and' at the end of a list). Not all consider it necessary, but I think it improves readability.
    
    * Update article.md
    
    Add a comma, minor wording adjustments
    
    * Update article.md
    
    'allow to' -> 'allow us to'
    optional comma
    
    * Fix minor grammatical error
    
    * Update article.md
    
    rephrasing
    
    * Update article.md
    
    if -> ifs
    Phrasing, punctuation.
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * re-import images from Sketch (no changes)
    
    * fixes
    
    * debugging
    
    * Update solution.md
    
    * minor
    
    * minor
    
    * fixes
    
    * fixes
    
    * fixes
    
    * fixes
    
    * fixes
    
    * fixes
    
    * fixes
    
    * fixes
    
    * fixes
    
    * minor
    SastraNababan authored Oct 12, 2019
    Configuration menu
    Copy the full SHA
    be32218 View commit details
    Browse the repository at this point in the history
Loading
X Tutup