X Tutup
Skip to content

fix cron-ci#7483

Merged
youknowone merged 2 commits intoRustPython:mainfrom
youknowone:ci-fixes
Mar 27, 2026
Merged

fix cron-ci#7483
youknowone merged 2 commits intoRustPython:mainfrom
youknowone:ci-fixes

Conversation

@youknowone
Copy link
Copy Markdown
Member

@youknowone youknowone commented Mar 23, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores

    • Updated CI workflow configuration to enable additional Rust compilation features and improve build coverage reporting.
    • Enhanced shell script command handling in CI pipelines for safer filename processing.

  • Tests

    • Improved test runner robustness with better error handling for edge cases.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 6401fa58-a631-4345-902e-360a0a2db154

📥 Commits

Reviewing files that changed from the base of the PR and between 4107217 and 36d9705.

📒 Files selected for processing (2)
  • .github/workflows/cron-ci.yaml
  • extra_tests/custom_text_test_runner.py
📝 Walkthrough

Walkthrough

CI workflow updates Rust feature flags (stdio, host_env) and improves shell command safety with null-delimiter handling. Test runner refactors method dict access into a helper function and makes module field extraction more robust with fallback logic.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/cron-ci.yaml		 Updated CARGO_ARGS to include stdio and host_env features; modified cargo llvm-cov command to match; changed Codecov action input parameter from file: to files:; reworked shell commands in benchmark job to use find -print0 with xargs -0 for safer filename handling.
Test Runner Refactoring
extra_tests/custom_text_test_runner.py		 Added _get_method_dict(test) helper to centralize retrieval of test method's underlying function __dict__, reducing repeated attribute access; made suite "module" field extraction more robust with conditional regex matching that falls back to str(test) if regex fails.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • moreal

Poem

🐰 Hop, skip, and a leap,
Features added, nice and deep,
Safer paths with null delimiters true,
Helper functions make code new,
CI workflows bloom in morning dew!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh mentioned this pull request Mar 24, 2026
Open
@youknowone youknowone marked this pull request as ready for review March 27, 2026 14:55
@youknowone youknowone merged commit fddd7cb into RustPython:main Mar 27, 2026
17 of 19 checks passed
@youknowone youknowone deleted the ci-fixes branch March 27, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@youknowone
X Tutup