Conversation
This reverts commit 153d0ee.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ) | ||
| return scope | ||
|
|
||
| @unittest.expectedFailure # TODO: RUSTPYTHON; 'a,' != '(a,)' |
There was a problem hiding this comment.
@youknowone should I open a feature request to ruff team about this? or should we just maintain our own fork of it? I am less in favor of maintaining a fork as it will require us:
- maintain a fork
- prevents us from publishing a new version to crates.io (unless we push the fork to crates.io)
There was a problem hiding this comment.
make a fork, write a feature but ask to merge it before using the fork. split the fork later when rejected. nothing to loose.
because we (and most of open source projects) always don't have enough engineering power for the project, upstreaming is the better choice when possible.
There was a problem hiding this comment.
Let's hope that they are fine with this astral-sh/ruff#21041
2 participants
Reverts #6206