This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[BUG] Mishandling message websocket updates#2452
Merged
Conversation
…ffkit's job and it's not meant to be done at this point, here we just need to identify the index of the modified object to apply the changes
…hen updating a section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Part of solving this bug was to make sure that
dataanddataSortedwere aligned withmessagesQuery. The way we are doing it today can generate data races in some edge cases, and these data races may make us to lose some update yet.In other words: the bug is fixed 💯 but we need to optimize the way we sync our "data pipeline" to avoid side effects caused by data races
Closes #2434