X Tutup
Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Add Japanese translation file#2145

Merged
rafaelks merged 1 commit intoRocketChat:developfrom
YuuTakahara:translation_ja
Aug 30, 2018
Merged

[NEW] Add Japanese translation file#2145
rafaelks merged 1 commit intoRocketChat:developfrom
YuuTakahara:translation_ja

Conversation

@YuuTakahara
Copy link
Contributor

@RocketChat/ios

Add japanese translation file.

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2018

CLA assistant check
All committers have signed the CLA.

@YuuTakahara YuuTakahara changed the title Add Japanese translation file [NEW]Add Japanese translation file Aug 30, 2018
@rafaelks rafaelks added this to the 3.1.0 milestone Aug 30, 2018
@rafaelks rafaelks changed the title [NEW]Add Japanese translation file [NEW] Add Japanese translation file Aug 30, 2018
@rafaelks
Copy link
Contributor

Looking awesome @YuuTakahara, thank you very much!

@rafaelks rafaelks merged commit d6c014c into RocketChat:develop Aug 30, 2018
@Sameesunkaria
Copy link
Contributor

@YuuTakahara Thanks a lot for the translations. 🙌🏻
There are a few new string in develop which are not synced with the Japanese strings file. Can you help translate those as well?

@YuuTakahara
Copy link
Contributor Author

YuuTakahara commented Aug 31, 2018

@rafaelks Thank you for the work.
Should I do something?
This is my first pull requuest, so there are a lot of things I do not know.

@YuuTakahara
Copy link
Contributor Author

@Sameesunkaria I can do it.
Specifically, what file or word translation is required?
Should I add ja.lproj to Rocket.Chat.iOS/Rocket.Chat.ShareExtension/Resources/?

@Sameesunkaria
Copy link
Contributor

@YuuTakahara your current changes have been merged into the codebase.

You can go through the changes I made in #2149 to the Japanese strings file, and add the translated versions of those strings in a new PR.

Sent with GitHawk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup