OperatorDoOnRequest.ParentSubscriber should be static class#2052
Merged
benjchristensen merged 1 commit intoReactiveX:1.xfrom Dec 24, 2014
Merged
OperatorDoOnRequest.ParentSubscriber should be static class#2052benjchristensen merged 1 commit intoReactiveX:1.xfrom
benjchristensen merged 1 commit intoReactiveX:1.xfrom
Conversation
Collaborator
Author
|
test failure looks to be unrelated |
Member
|
My bad. Fixed in #2053 |
Collaborator
Author
|
Just to clarify, @akarnokd fixed the unrelated test, this PR is still valid. |
benjchristensen
added a commit
that referenced
this pull request
Dec 24, 2014
OperatorDoOnRequest.ParentSubscriber should be static class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor fix this.
OperatorDoOnRequest.ParentSubscriberdoes not require access to the state or methods of its surrounding class thus can be static.