AI Code Review Cycle 1/3 - Reviewer: claude-opus-4-6 - APPROVE. This PR cleanly re-enables PSX multi-tap support. The implementation correctly uses MednafenGameCoreOptions for serial lookup, MDFNI_SetSettingB for settings, and modernizes pollControllers to support up to 8 players. No CRITICAL or MAJOR issues. MINOR: PVCoreBridge EmulatorCoreControllerDataSource.swift:58 has a pre-existing bug where case 8 returns controller7 instead of controller8, now reachable with 8-player support enabled by this PR.

AI Code Review - Cycle 1/3. Reviewer: claude-opus-4-6. Summary: Clean, well-scoped change that re-enables PSX multi-tap support. The implementation correctly looks up game serials, configures Mednafen multitap settings, re-initializes input buffers, and generalizes pollControllers to support up to 8 players. No thread safety, Realm, or upstream submodule concerns. CRITICAL - none. MAJOR - none. MINOR: (1) EmulatorCoreControllerDataSource.swift:58 - Pre-existing bug exposed: case 8 returns controller7 instead of controller8. Player 8 gets wrong controller. Follow-up fix recommended. (2) executeFrameSkippingFrame only checks controllers 1-4 to decide whether to poll but game may support 5-8. NIT: controllerForPlayer called 4x per frame vs direct property access - negligible overhead. Verdict: APPROVE

AI Code Review — Cycle 1/3

Reviewer: claude-opus-4-6

Summary

This PR re-enables PSX multi-tap support in the Mednafen core bridge by uncommenting and modernizing the multitap detection logic. The multitap configuration logic itself (serial lookup, port settings, input buffer re-initialization) looks correct and well-structured. However, the controller polling refactor introduces a critical crash: controllerForPlayer: is called on self (a MednafenGameCoreBridge which inherits from PVCoreObjCBridge), but that method is only implemented on PVEmulatorCore (the Swift wrapper), not on the ObjC bridge class itself. This will cause an unrecognized selector crash at runtime in both pollControllers and executeFrameSkippingFrame:.

Issues

🔴 CRITICAL (must fix)

• Cores/Mednafen/Sources/MednafenGameCoreBridge/MednafenGameCoreBridge.mm:~1161 — [self controllerForPlayer:(NSUInteger)(playerIndex + 1)] will crash with unrecognized selector sent to instance. The method controller(forPlayer:) is defined on the Swift EmulatorCoreControllerDataSource protocol and implemented in PVEmulatorCore+Controller.swift, but MednafenGameCoreBridge inherits from PVCoreObjCBridge which does not implement this method. The same crash occurs at ~1192 in executeFrameSkippingFrame:. Fix: Either revert to using self.controller1/self.controller2/etc. properties (which ARE declared on PVCoreObjCBridge) with a helper switch, or implement controllerForPlayer: directly on MednafenGameCoreBridge. For 8-player support, a simple switch on playerIndex accessing self.controller1 through self.controller8 would work.

🟠 MAJOR (should fix)

• Cores/Mednafen/Sources/MednafenGameCoreBridge/MednafenGameCoreBridge.mm:~1192 — In executeFrameSkippingFrame:, the change only checks controllers 1–4 but pollControllers now supports up to 8 players. If players 5–8 have controllers connected but 1–4 don't, pollControllers won't be called. Should check up to 8, or better yet, always call pollControllers when multi-tap is active.
• Cores/Mednafen/Sources/MednafenGameCoreBridge/MednafenGameCoreBridge.mm:~929 — Multi-tap settings (psx.input.pport1.multitap, psx.input.pport2.multitap) are set to true when a multi-tap game is loaded, but never explicitly reset to false for non-multi-tap games. If Mednafen settings persist across game loads (e.g., if the emulator is reused without full reinitialization), a subsequent 2-player game could incorrectly have multi-tap enabled. Consider adding explicit MDFNI_SetSettingB("psx.input.pport1.multitap", false) / pport2 in an else branch.

🟡 MINOR (optional)

• none

⚪ NIT

• none

Verdict: REQUEST_CHANGES 🔧

🤖 Claude Code fixer has been dispatched to address CRITICAL and MAJOR issues automatically.

⚠️ Max review cycles (3) reached. Escalating to human review. See previous reviews for outstanding issues.

AI Code Review - Cycle 1/3

Reviewer: claude-opus-4-6

Summary: Clean re-enablement of previously disabled PSX multi-tap support in the Mednafen core bridge. The code correctly looks up game serials against a known multi-tap dictionary, configures port multitap settings via MDFNI_SetSettingB, re-initializes input buffers for up to 8 players, and expands pollControllers/executeFrameSkippingFrame to support players 5-8. The else branch that explicitly disables multitap for non-multitap games is a good defensive practice to prevent setting bleed across game loads. Buffer access is safe (inputBuffer[13] accommodates indices 0-7).

CRITICAL - none | MAJOR - none

MINOR - EmulatorCoreControllerDataSource.swift:58 - Pre-existing bug: case 8 returns controller7 instead of controller8. This PR does not use controller(for:) in its new code paths (it accesses self.controller8 directly), so no issues here, but the helper is broken for 8-player scenarios elsewhere. Consider fixing in a follow-up.

NIT - MednafenGameCoreBridge.mm - The initial SetInput loop (lines 903-911, unchanged) runs with multiTapPlayerCount=2 before the new multitap detection code updates it and re-calls SetInput. Works correctly but could be slightly cleaner if reordered. Not a bug.

Verdict: APPROVE

AI Code Review Cycle 1/3 - Reviewer: claude-opus-4-6 - APPROVE. Clean re-enablement of PSX multi-tap support. No CRITICAL or MAJOR issues. One NIT: duplicated analog-center + SetInput loop could be extracted into helper.

AI Code Review Cycle 1/3 - Reviewer: claude-opus-4-6 - Verdict: APPROVE - No CRITICAL or MAJOR issues found. See status comment for full details.