Builds for this Pull Request are available at
Provenance-iOS-v3.0.0(5746).ipa
Provenance-Lite-iOS-v3.0.0(5746).ipa
Provenance-Lite-tvOS-v3.0.0(5746).ipa
Provenance-tvOS-v3.0.0(5746).ipa
Have a nice day.

Status Update from PR #2373 Analysis

Audited the feature/new-cores/libretrogles branch (PR #2373) vs current develop.

What PR #2373 did for Desmume2015

The PR was mostly a cleanup pass — removing 355 lines of commented-out Flycast-copied boilerplate code from PVDesmume2015Core.mm that had been incorrectly carried over from the Flycast core. The result was a much cleaner file.

What's been done on develop since then (this is the important part)

Develop has made significant progress on Desmume2015:

• 408589307 — "desmume2015 core options and touch" — touch/mouse inputs added to libretro.h wrapper
• d6796205d — "desmume2015 disable skins again for now" — skins temporarily disabled
• Full virtual keyboard + mouse overlay system merged (PRs [Agent] feat: Add supportsVirtualKeyboard/Mouse to PVEmulatorCore #2587, [Agent] feat(PVUI): Compact keyboard + function-row-only virtual keyboard variants #2588, [Agent] feat: Harden keyboard event pipeline for libretro cores #2589, [Agent] PVUI: Mouse cursor overlay for pointer-based cores #2590, [Agent] feat: VirtualKeyboardView — SwiftUI QWERTY overlay with haptics and dismiss gesture #2591, [Agent] feat: Wire virtual keyboard and cursor into PVEmulatorViewController #2594)
• supportsVirtualMouse API now available in PVEmulatorCore for touch-based input
• DS dual-screen skin system merged: 3fdbdd905 — "feat: DS dual-screen skin support — Phases 1-3 ([Agent] DS dual-screen skin: Phases 1-3 (enable skins, NDS layout, touch translation) #2612)" — this is the big one!

Current state

As of develop:

• Dual-screen skin support is merged (Phase 1-3) — screens can resize/move
• Touch events are forwarding to the libretro.h wrapper
• Skins are currently disabled (d679620)
• The virtual mouse/cursor overlay is available if touch mode needs it

What still needs doing

1. Re-enable skins — They were disabled for a reason (likely a crash or layout bug). Needs investigation to determine what broke and fix it with the new dual-screen system.
2. Verify touch input path — With the new supportsVirtualMouse API and the mouse cursor overlay, touch should work more reliably now. The dual-screen skin system and the touch forwarding need to be wired together.
3. Core update — The upstream Desmume2015 code itself is old; may be worth checking if there's a newer version.

Relationship to DS dual-screen epic

Issue #2482 lists dual-screen skins as requiring native cores (Desmume2015, MelonDS) working first. With the dual-screen skin system now merged in #2612, the bottleneck has shifted back to the core touch/skin integration.

Related: #2373 (parent PR), #2482 (Core Updates epic), #3fdbdd905 (DS dual-screen skin PR)