Merged
Conversation
|
Hi @jsoref, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
| * `Issue-Bug`: the issue is reporting a bug | ||
| * `Issue-Discussion`: the issue may not have a clear classification yet. | ||
| The issue may generate a [RFC][ln-rfc] or maybe be reclassified as a bug or enhancement. | ||
| The issue may generate an [RFC][ln-rfc] or maybe be reclassified as a bug or enhancement. |
Contributor
Author
There was a problem hiding this comment.
The reason for an instead of a in an RFC is that RFC is pronounced arr, eff, cee and thus an arr-eff-cee is correct even though the first letter of RFC appears to be a consonant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split into individual commits to make it easier to review, but they can certainly be squashed.