X Tutup
Skip to content

Fix Get-Service non-terminating error message to include category#20276

Merged
iSazonov merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:service-error
Sep 19, 2023
Merged

Fix Get-Service non-terminating error message to include category#20276
iSazonov merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:service-error

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Sep 14, 2023 •
edited
Loading

PR Summary

Get-Service cmdlet has a common method for emitting non-terminating error message. Unfortunately, it assumed that if there isn't an inner exception message to just leave the content blank when formatting the error string. Fix here is that if there isn't an inner exception message, we use the string value of the error category instead of an empty string.

image

PR Context

Fix #20187

PR Checklist

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated bot commented Sep 14, 2023

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.cs : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 14, 2023
@iSazonov iSazonov merged commit af1d99e into PowerShell:master Sep 19, 2023
@SteveL-MSFT SteveL-MSFT deleted the service-error branch October 3, 2023 15:41
adityapatwardhan pushed a commit that referenced this pull request Oct 19, 2023
@SteveL-MSFT @adityapatwardhan
Fix Get-Service non-terminating error message to include category (#…
423d6d9 
…20276)

et-Service cmdlet has a common method for emitting non-terminating error message. Unfortunately, it assumed that if there isn't an inner exception message to just leave the content blank when formatting the error string. Fix here is that if there isn't an inner exception message, we use the string value of the error category instead of an empty string.
@adityapatwardhan adityapatwardhan mentioned this pull request Oct 19, 2023
Merged
adityapatwardhan added a commit that referenced this pull request Oct 19, 2023
@adityapatwardhan
Fix Get-Service non-terminating error message to include category (#…
b49de75 
…20276) (#20529)
@B-Art
Copy link
Copy Markdown

B-Art commented Aug 2, 2024

McpManagementService
NPSMSvc_*
and
WaaSMedicSvc
Still give a PermissionDenied message.

sfc /scannow Solved the MUI message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@iSazonov iSazonov

Labels

BackPort-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get-Service | Empty fields dedicated to error messages

4 participants

@SteveL-MSFT @B-Art @iSazonov @adityapatwardhan
X Tutup