Fixing PS 7.4 regression that is breaking DSCv3#20268
Fixing PS 7.4 regression that is breaking DSCv3#20268anmenaga merged 1 commit intoPowerShell:masterfrom
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Since these are only used by PSDSC, would it make more sense to make changes in that code to be self-contained rather than reaching into SMA.dll?
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Discussed with Andrew. Since we still have some DSC code in SMA.dll, it would be simpler for now to put these lines back and remove them along with the remaining DSC code in the future aligned with a new PSDSC 3.0 release
|
|
||
| internal static class Separators | ||
| { | ||
| internal static readonly char[] Backslash = new char[] { '\\' }; |
There was a problem hiding this comment.
I wander how and why DSC uses the internal?
PR Summary
Some constants/resource strings, used by DSCv3, were accidentally removed by these 2 PRs:
#18383
#18154
Adding these back to PS 7.4 to avoid re-release of DSCv3 module.
PR Context
DSC repo issue: PowerShell/DSC#128
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).