Block any preview vPack release#20243
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
|
||
| - powershell: | | ||
| if($env:RELEASETAGVAR -match '-') { | ||
| throw "Don't release a preview build without coordinating with Windows Engineering Build Tools Team" |
There was a problem hiding this comment.
Will this fail the release pipeline? It may be better to not fail the pipeline, but just make it a non-op?
There was a problem hiding this comment.
We should fail the pipeline where the action fails. Hiding failures leads to confusion.
|
📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://forms.office.com/r/P926k48jRJ |
PR Summary
Block vPack release if it has a
-in the release tagPR Context
Windows does not want to consume Preview/RC vPacks and they don't effectively use semantic versioning.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).