Revert "Fix slow execution when many breakpoints are used (#14953)" by andyleejordan · Pull Request #20042 · PowerShell/PowerShell

andyleejordan · 2023-07-28T21:03:41Z

PR Summary

This reverts commit d8decdc.

This commit broke the VS Code extension's debugger, and should be
reverted until such time that the root cause is found and a fix applied.

Also disable false assertion that blocks pwsh on Parallels VM.

PR Context

The resolves PowerShell/vscode-powershell#4668, where the VS Code extension's debugger no longer worked with preview.4. First I confirmed that it worked with preview.3, then I cloned and built from source. After looking at the diff between preview.3 and preview.4 for changes that affected the debugger in the engine, I only found #14953. While I've looked at the changes in that PR, I haven't yet isolated what broke things; but I reverted the merge commit and confirmed the debugger works again.

PR Checklist

This reverts commit d8decdc. This commit broke the VS Code extension's debugger, and should be reverted until such time that the root cause is found and a fix applied.

pull-request-quantifier-deprecated · 2023-07-28T21:04:10Z

This PR has 85 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Small
Size       : +39 -46
Percentile : 34%

Total files changed: 4

Change summary by file extension:
.cs : +39 -46

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

daxian-dbw · 2023-07-28T23:47:11Z

src/System.Management.Automation/engine/Interop/Windows/QueryDosDevice.cs

+                            // TODO: This actually hit in a Parallels VM, so it's not quite dead yet!
+                            // Diagnostics.Assert(false, "Really it is a dead code since GetDosDevice() is called only if PSDrive.DriveType == DriveType.Network");


Please open an issue about this and mark it "7.4-Blocking".

Which commit, the debugger being broken or the executable failing on my VM, or both?

Open an issue about the fact that this assertion is wrong on Parallels VM. This code path needs to be reviewed as the assumption is incorrect. Can you please find out what the PSDrive.DriveType is when running in Parallel VM?

@andyleejordan Can you please check what PSDrive.DriveType is when the assertion fails in Parallel VM and share that info in #20043? Thanks!

andyleejordan · 2023-07-29T00:02:11Z

@daxian-dbw filed #20043 and #20044

iSazonov · 2023-07-29T02:23:36Z

src/System.Management.Automation/engine/Interop/Windows/QueryDosDevice.cs

                        {
-                            Diagnostics.Assert(false, "Really it is a dead code since GetDosDevice() is called only if PSDrive.DriveType == DriveType.Network");
+                            // TODO: This actually hit in a Parallels VM, so it's not quite dead yet!
+                            // Diagnostics.Assert(false, "Really it is a dead code since GetDosDevice() is called only if PSDrive.DriveType == DriveType.Network");


This is a fallback from another p/invoke GetUNCForNetworkDrive - it is main code path. This says that something can work incorrectly on Parallels VM.
So I suggest investigate the issue in separate PR. Perhaps we need a workaround as we did for WSL.

fflaten · 2023-07-30T16:05:00Z

Close this? See #20046 for root-cause fix to breakpoints issue. Parallels issue tracked in #20043

daxian-dbw · 2023-07-31T16:23:25Z

Superseded by #20046

andyleejordan added 2 commits July 28, 2023 13:54

Disable false assertion that blocks pwsh on Parallels VM

2ad1245

Revert "Fix slow execution when many breakpoints are used (#14953)"

df65f8f

This reverts commit d8decdc. This commit broke the VS Code extension's debugger, and should be reverted until such time that the root cause is found and a fix applied.

andyleejordan requested a review from daxian-dbw as a code owner July 28, 2023 21:03

pull-request-quantifier-deprecated bot added the Small label Jul 28, 2023

andyleejordan mentioned this pull request Jul 28, 2023

Allow means to avoid adding an absolute Cwd path to the workspace settings PowerShell/vscode-powershell#4557

Closed

2 tasks

daxian-dbw reviewed Jul 28, 2023

View reviewed changes

iSazonov reviewed Jul 29, 2023

View reviewed changes

fflaten mentioned this pull request Jul 30, 2023

Use OrdinalIgnoreCase to lookup script breakpoints #20046

Merged

22 tasks

daxian-dbw closed this Jul 31, 2023

andyleejordan mentioned this pull request Jul 31, 2023

Assertion in QueryDosDevice.cs failing in Parallels VM #20043

Open

5 tasks

andyleejordan deleted the andyleejordan/fix-debugger branch July 31, 2023 22:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Fix slow execution when many breakpoints are used (#14953)" #20042

Revert "Fix slow execution when many breakpoints are used (#14953)" #20042
andyleejordan wants to merge 2 commits intomasterfrom
andyleejordan/fix-debugger

andyleejordan commented Jul 28, 2023

Uh oh!

pull-request-quantifier-deprecated bot commented Jul 28, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

daxian-dbw Jul 28, 2023

Uh oh!

andyleejordan Jul 28, 2023

Uh oh!

daxian-dbw Jul 29, 2023

Uh oh!

daxian-dbw Jul 31, 2023

Uh oh!

andyleejordan commented Jul 29, 2023

Uh oh!

iSazonov Jul 29, 2023 •

edited

Loading

Uh oh!

fflaten commented Jul 30, 2023 •

edited

Loading

Uh oh!

daxian-dbw commented Jul 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		// TODO: This actually hit in a Parallels VM, so it's not quite dead yet!
		// Diagnostics.Assert(false, "Really it is a dead code since GetDosDevice() is called only if PSDrive.DriveType == DriveType.Network");

Conversation

andyleejordan commented Jul 28, 2023

PR Summary

PR Context

PR Checklist

Uh oh!

pull-request-quantifier-deprecated bot commented Jul 28, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

daxian-dbw Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

andyleejordan Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

daxian-dbw Jul 29, 2023

Choose a reason for hiding this comment

Uh oh!

daxian-dbw Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

andyleejordan commented Jul 29, 2023

Uh oh!

iSazonov Jul 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fflaten commented Jul 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daxian-dbw commented Jul 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iSazonov Jul 29, 2023 •

edited

Loading

fflaten commented Jul 30, 2023 •

edited

Loading