Test fixes which fail during release testing.#20028
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Jul 27, 2023
Merged
Test fixes which fail during release testing.#20028adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
A number of changes to reduce test failures during release test. Skip all tests for Send-MailMessage, this cmdlet is deprecated. Improve robustness for remove certificates in AfterAll. Check status of reply for test-connection before checking address.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
adityapatwardhan
approved these changes
Jul 26, 2023
TravisEz13
reviewed
Jul 27, 2023
Member
TravisEz13
left a comment
There was a problem hiding this comment.
reviewed all but tab completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of changes to reduce test failures during release test. Skip all tests for Send-MailMessage, this cmdlet is deprecated. Improve robustness for remove certificates in AfterAll. Check status of reply for test-connection before checking address.
PR Summary
PR Context
The only controversial change may be the skipping of tests for
Send-MailMessage. Since this cmdlet is deprecated and unsupported, we probably don't need to test it. We still include it, and compliance checks will still occur, but functional tests may now be skipped. These tests are not consistent in our release tests and cause additional inspections when we do a release build.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).