Add Help proxy function for non-Windows platforms#19972
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Jul 17, 2023
Merged
Add Help proxy function for non-Windows platforms#19972adityapatwardhan merged 3 commits intoPowerShell:masterfrom
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
adityapatwardhan
approved these changes
Jul 17, 2023
adityapatwardhan
requested changes
Jul 17, 2023
Member
adityapatwardhan
left a comment
There was a problem hiding this comment.
Build seems to be failing due to preprocessor statements not being correct. Please check.
adityapatwardhan
approved these changes
Jul 17, 2023
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add
Helpproxy function for non-Windows platforms.helpfunction includes the-ShowWindowparameter on non-Windows platforms #19904PR Context
The original proxy function had been updated to support non-Windows platforms, however, it included the
-ShowWindowparameter, which is not supported or available on macOS and Linux.This PR creates two versions of the proxy function:
more.comorlessdepending on the platform. Now defaults tomore.com.-ShowWindowparametermore.comorlessdepending on the platform. Now defaults toless.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).